I have multiple X10 motion sensors with switch problems. As everyone has speculated the push button contacts oxidize with age and you start getting switch bounce or noisy switch. I have just sprayed contact cleaner on the switch and between the switch and the PC board which has helped, at least temporarily. I just use a cheap contact cleaner from Home Depot, Menards, Lowes, etc.
About the only place I was willing to shell out bigger bucks for a contact cleaner, is many moons ago I got some stuff from Craig (I think) that claimed to become more conductive under mechanical pressure. It was a brush-on liquid. I removed every breaker in the breaker box and "painted" this on the breaker busses. To my surprise X10 communications/signal reliability did improve. Unfortunately that was back in '93 and I don't remember the name of the magic elixir.