I knew I asked the question on the old HG forum but couldn't find it until just last night. I believe I found the issue and I suppose it makes sense...It's just not exactly how I thought the scheduler worked. I can't access the HG club site from work for filtering reasons so I can't post the link.
Anyway, the way the old scheduler works is you specify a specific time/date combination via a crontab formatted statement into the "Scheduled On/Off" app for a module. When the app runs (2x per minute) and the condition matches it will fire the event (2x generally 30 seconds apart). With the new scheduler, you can specify an event as a range. So, instead of saying "I want the lights to turn on if the month is 11 or 12 and at sunset", you can instead say "I want the lights to turn on if the date is between black friday and new years and the time is sunset". The subtle difference is that the old way will trigger at the minute of sunset in Nov and Dec whereas the new scheduler will trigger if the date is between black friday and new years and after sunset. In other words, the event will trigger ON when it's after sunset every time it runs the code in the new model. The same happens for the OFF event. As a result, things don't quite work as expected. (I can't access the thread, so I may have slightly messed that up.)
I modified the events last night and hopefully they will work. I'll know when I get home since the lights should be on.
In any case, the current scheduler is better but it requires understanding when events will fire so things will operate as expected. I'm not sure I'd consider this a bug because the person who helped back then was working with Gene on that section of code IIRC.